Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a Running condition when the XGBoostJob is completed and doesn't have a Running condition #1789

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I fixed the reconciling error in XGBoost Job.
When XGBoostJob is completed (succeeded or failed) before the controller sets a Running condition, XGBoostJob finishes without a Running condition.

So, I modified the controller so that the controller can set a Running condition when the XGboostJob is completed and doesn't have a Running condition.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of #1779

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Mar 28, 2023

Pull Request Test Coverage Report for Build 4546766224

  • 12 of 22 (54.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 39.611%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/xgboost/status.go 12 15 80.0%
pkg/controller.v1/xgboost/xgboostjob_controller.go 0 7 0.0%
Totals Coverage Status
Change from base Build 4529361961: 0.07%
Covered Lines: 2751
Relevant Lines: 6945

💛 - Coveralls

…have a Running condition

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
Copy link
Member Author

@terrytangyuan I addressed your comment. PTAL.

@terrytangyuan
Copy link
Member

/lgtm

@tenzen-y
Copy link
Member Author

/assign @johnugeorge @nagar-ajay

@google-oss-prow
Copy link

@tenzen-y: GitHub didn't allow me to assign the following users: nagar-ajay.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @johnugeorge @nagar-ajay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnugeorge
Copy link
Member

Somehow, I missed this PR

Sorry for the delay @tenzen-y

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8a066f9 into kubeflow:master Apr 10, 2023
@tenzen-y tenzen-y deleted the fix-xgboost-bug branch April 17, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants