Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch volcano log when e2e failed #1837

Merged
merged 1 commit into from
Jun 25, 2023
Merged

fetch volcano log when e2e failed #1837

merged 1 commit into from
Jun 25, 2023

Conversation

lowang-bh
Copy link
Member

What this PR does / why we need it:

get volcano scheduler log and describe podgroup when e2e test failed

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow google-oss-prow bot requested review from kuizhiqing and tenzen-y June 18, 2023 09:38
@coveralls
Copy link

coveralls commented Jun 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5312480601

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 34.084%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 7 78.79%
Totals Coverage Status
Change from base Build 5306620240: -0.09%
Covered Lines: 3362
Relevant Lines: 9864
💛 - Coveralls

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Jun 18, 2023
@lowang-bh
fetch volcano log when e2e failed
5e159f9 
Signed-off-by: lowang-bh <lhui_wang@163.com>
tenzen-y
tenzen-y reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @terrytangyuan @johnugeorge @gaocegege

@google-oss-prow google-oss-prow bot added the lgtm label Jun 23, 2023
@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7e0eea6 into kubeflow:master Jun 25, 2023
@lowang-bh lowang-bh deleted the volcano-e2e branch June 26, 2023 02:27
@lowang-bh lowang-bh mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@johnugeorge johnugeorge johnugeorge left review comments

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@johnugeorge johnugeorge

@terrytangyuan terrytangyuan

@gaocegege gaocegege

@tenzen-y tenzen-y

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lowang-bh @coveralls @johnugeorge @tenzen-y @terrytangyuan @gaocegege