Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate code of add task spec annotation #1839

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Jun 23, 2023

/kind cleanup

What this PR does / why we need it:

add volcano task spec annotation already done in decorator

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5353154045

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 34.186%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 11 78.86%
Totals Coverage Status
Change from base Build 5306620240: 0.01%
Covered Lines: 3369
Relevant Lines: 9855

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 23, 2023

Pull Request Test Coverage Report for Build 5353620244

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 34.165%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 79.7%
Totals Coverage Status
Change from base Build 5306620240: -0.01%
Covered Lines: 3367
Relevant Lines: 9855

💛 - Coveralls

Signed-off-by: lowang-bh <lhui_wang@163.com>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/assign @johnugeorge @gaocegege @terrytangyuan

@johnugeorge
Copy link
Member

Thanks @lowang-bh

/lgtm
/approve

@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit af8a77d into kubeflow:master Jun 25, 2023
@lowang-bh lowang-bh deleted the improve branch June 26, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants