-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring tests in common/controller.v1 #1843
Refactoring tests in common/controller.v1 #1843
Conversation
Pull Request Test Coverage Report for Build 5446399997
💛 - Coveralls |
81bec1c
to
410261f
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
410261f
to
568d787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@terrytangyuan Thanks for the review. Can you restart CI |
done |
I will work on improving flaky tests... |
What this PR does / why we need it:
I refactored tests in common/controller.v1. And then, I removed
TestJobController
.Also, I moved the following tests into
"Test for controller.v1/common"
in TFJob ones since those tests deeply depend on Reconciler, such asTFJobReconciler
:TestCleanupJobIfTTL
TestCleanupJob
TestJobController_CreateNewService
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Part-of: #1816
Checklist: