Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up /pkg/common/util/v1 #1845

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jul 3, 2023

What this PR does / why we need it:
I cleaned up /pkg/common/util/v1. As I check the package, the package is used only by tensorflow. So I moved the package to /pkg/controller.v1/tensorflow and removed unused utils.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of: #1816

Checklist:

  • Docs included if any changes are user facing

@tenzen-y tenzen-y marked this pull request as ready for review July 3, 2023 18:35
@google-oss-prow google-oss-prow bot requested review from jinchihe and kuizhiqing July 3, 2023 18:35
@tenzen-y tenzen-y changed the title Clean up /pkg/common/util/v1 WIP: Clean up /pkg/common/util/v1 Jul 3, 2023
@coveralls
Copy link

coveralls commented Jul 3, 2023

Pull Request Test Coverage Report for Build 5447744222

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 33.686%

Totals Coverage Status
Change from base Build 5446712781: 0.1%
Covered Lines: 3283
Relevant Lines: 9746

💛 - Coveralls

@tenzen-y tenzen-y force-pushed the clean-up-commonutils branch 2 times, most recently from 744ecec to f9170f6 Compare July 3, 2023 18:53
corev1 "k8s.io/api/core/v1"

commonv1 "github.com/kubeflow/training-operator/pkg/apis/kubeflow.org/v1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove commonv1 import in follow-ups.

@tenzen-y tenzen-y changed the title WIP: Clean up /pkg/common/util/v1 Clean up /pkg/common/util/v1 Jul 3, 2023
@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 3, 2023

/assign @johnugeorge @terrytangyuan

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the clean-up-commonutils branch from f9170f6 to b4f298a Compare July 3, 2023 19:00
@johnugeorge
Copy link
Member

Looks great.
Thanks @tenzen-y for this work

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 3, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 40454af into kubeflow:master Jul 3, 2023
@tenzen-y tenzen-y deleted the clean-up-commonutils branch July 3, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants