Clean up /pkg/common/util/v1 #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzen-y
changed the title
Pull Request Test Coverage Report for Build 5447744222
💛 - Coveralls |
tenzen-y
force-pushed
the
clean-up-commonutils
branch
2 times, most recently
from
744ecec
to
f9170f6
Compare
tenzen-y
commented
Jul 3, 2023
| corev1 "k8s.io/api/core/v1" | ||
|
|
||
| commonv1 "github.com/kubeflow/training-operator/pkg/apis/kubeflow.org/v1" |
There was a problem hiding this comment.
I will remove commonv1 import in follow-ups.
tenzen-y
changed the title
|
/assign @johnugeorge @terrytangyuan |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
clean-up-commonutils
branch
from
f9170f6
to
b4f298a
Compare
5 tasks
|
Looks great. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I cleaned up
/pkg/common/util/v1. As I check the package, the package is used only by tensorflow. So I moved the package to/pkg/controller.v1/tensorflowand removed unused utils.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Part-of: #1816
Checklist: