Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for suspend semantics #1853

Closed
wants to merge 5 commits into from

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jul 9, 2023

What this PR does / why we need it:
I implemented the suspend semantics to Jobs:

  • PyTorchJob
  • TFJob
  • MXJob
  • PaddleJob
  • MPIJob
  • XBGoostJob
  • Reconciler.v1

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1519

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tenzen-y
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5500278893

  • 49 of 136 (36.03%) changed or added relevant lines in 15 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 33.502%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/common/pod.go 0 1 0.0%
pkg/controller.v1/mpi/mpijob_controller.go 4 5 80.0%
pkg/controller.v1/pytorch/hpa.go 13 15 86.67%
pkg/controller.v1/pytorch/pytorchjob_controller.go 6 9 66.67%
pkg/controller.v1/xgboost/xgboostjob_controller.go 0 4 0.0%
pkg/apis/kubeflow.org/v1/zz_generated.deepcopy.go 0 5 0.0%
pkg/controller.v1/mxnet/mxjob_controller.go 0 5 0.0%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 2 7 28.57%
pkg/reconciler.v1/common/job.go 0 6 0.0%
pkg/apis/kubeflow.org/v1/openapi_generated.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 4 79.37%
Totals Coverage Status
Change from base Build 5468257726: 0.5%
Covered Lines: 3241
Relevant Lines: 9674

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 9, 2023

Pull Request Test Coverage Report for Build 5501322598

  • 54 of 138 (39.13%) changed or added relevant lines in 15 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+3.9%) to 36.944%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/common/pod.go 0 1 0.0%
pkg/controller.v1/mpi/mpijob_controller.go 4 5 80.0%
pkg/controller.v1/pytorch/hpa.go 13 15 86.67%
pkg/controller.v1/mxnet/mxjob_controller.go 3 6 50.0%
pkg/controller.v1/pytorch/pytorchjob_controller.go 6 9 66.67%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 4 8 50.0%
pkg/controller.v1/xgboost/xgboostjob_controller.go 0 4 0.0%
pkg/apis/kubeflow.org/v1/zz_generated.deepcopy.go 0 5 0.0%
pkg/reconciler.v1/common/job.go 0 6 0.0%
pkg/apis/kubeflow.org/v1/openapi_generated.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 7 79.28%
Totals Coverage Status
Change from base Build 5468257726: 3.9%
Covered Lines: 3574
Relevant Lines: 9674

💛 - Coveralls

@google-oss-prow google-oss-prow bot added size/XXL and removed size/XL labels Jul 9, 2023
@tenzen-y
Copy link
Member Author

I will create separate PR for each framework since this PR is too big.

@tenzen-y tenzen-y mentioned this pull request Jul 11, 2023
1 task
@tenzen-y
Copy link
Member Author

/close

@google-oss-prow
Copy link

@tenzen-y: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot closed this Jul 21, 2023
@tenzen-y tenzen-y deleted the suspend-semantic branch July 21, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support queue-related logic with kube-queue
2 participants