Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the cleanPodPolicyPointer function global #1858

Merged

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I made the cleanPodPolicyPointer function global.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y
Copy link
Member Author

/assign @johnugeorge @terrytangyuan

@tenzen-y tenzen-y changed the title Make the cleanPodPolicyPointer function golobal Make the cleanPodPolicyPointer function global Jul 11, 2023
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the commonize-pointer-cleanPodPolicy branch from be57c37 to ad36976 Compare July 11, 2023 08:01
@coveralls
Copy link

coveralls commented Jul 11, 2023

Pull Request Test Coverage Report for Build 5517340751

  • 6 of 8 (75.0%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 32.939%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/kubeflow.org/v1/paddlepaddle_defautls.go 0 1 0.0%
pkg/apis/kubeflow.org/v1/pytorch_defaults.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 79.17%
Totals Coverage Status
Change from base Build 5511536982: -0.02%
Covered Lines: 3172
Relevant Lines: 9630

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 11, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a3a2972 into kubeflow:master Jul 11, 2023
@tenzen-y tenzen-y deleted the commonize-pointer-cleanPodPolicy branch July 11, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants