Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Condition and ReplicaStatus optional #1862

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I made jobStatus.Condition and jobStatus.replicaStatus optional. We shouldn't make those fields necessary since those fields can be null.

/assign @johnugeorge

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5541650459

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 32.962%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 78.98%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 59.95%
Totals Coverage Status
Change from base Build 5534487622: -0.2%
Covered Lines: 3194
Relevant Lines: 9690

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5541650459

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 32.982%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 79.17%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 59.95%
Totals Coverage Status
Change from base Build 5534487622: -0.1%
Covered Lines: 3196
Relevant Lines: 9690

💛 - Coveralls

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 13, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 72f2512 into kubeflow:master Jul 13, 2023
25 checks passed
@tenzen-y tenzen-y deleted the job-status-optional branch July 14, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants