-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up controllers using goroutines to start the manager quickly #1869
Set up controllers using goroutines to start the manager quickly #1869
Conversation
Pull Request Test Coverage Report for Build 5631716043
💛 - Coveralls |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
d0c4451
to
893d329
Compare
Great. This is a needed fix which will reduce the start up time. However, timeout issue can still happen right? |
Yea, the potential issue still is left. However, I believe this improvement is effective for many situations since the manager starts without waiting for registering controllers.
|
Are there side effects in declaring readiness before controllers are ready? |
I think there aren't exist side effects even if users create XXXJobs before all controllers are registered to the manager. |
Thanks @tenzen-y |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The training-operator has many controllers, and each controller needs access to the kube-apiserver while launching.
So, in the heavy load cluster, the training operator can not start by timeout period.
Related to: #1841
By this PR, the training operator starts the manager not to wait for completed to register all controllers.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: