Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage kube-delivery image from training-operator and update it #1909

Merged
merged 15 commits into from
Sep 8, 2023

Conversation

rpemsel
Copy link
Contributor

@rpemsel rpemsel commented Sep 8, 2023

What this PR does / why we need it:

When running an MPI Job kubectl is required to start the mpi binary on the workers. The launcher connects to the workers using kubectl. This kubectl is provided by an init container. That init container provides a very old version of kubectl. Also the image for the init container is not controlled inside the training operator repository. So with the pull request the image is managed within the repository.

Also it uses a 1.27 version of the kubectl that provides the latest features and fixes.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1899

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Sep 8, 2023
@rpemsel rpemsel changed the title New kubedelivery image Manage kube-delivery image from training-operator and update it Sep 8, 2023
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rpemsel, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit afba76b into kubeflow:master Sep 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update kubectl version used in kubectl launcher
3 participants