-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage kube-delivery image from training-operator and update it #1909
Manage kube-delivery image from training-operator and update it #1909
Conversation
…-kubedelivery-image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rpemsel, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
When running an MPI Job kubectl is required to start the mpi binary on the workers. The launcher connects to the workers using kubectl. This kubectl is provided by an init container. That init container provides a very old version of kubectl. Also the image for the init container is not controlled inside the training operator repository. So with the pull request the image is managed within the repository.
Also it uses a 1.27 version of the kubectl that provides the latest features and fixes.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1899
Checklist: