Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating service account where approriate for MPI Job #1917

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

rpemsel
Copy link
Contributor

@rpemsel rpemsel commented Sep 20, 2023

What this PR does / why we need it: If a MPI job is supposed to run with a certain K8s service account, then this service account can now be used.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1897

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Sep 20, 2023

Pull Request Test Coverage Report for Build 6244561289

  • 15 of 19 (78.95%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 42.885%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/mpi/mpijob_controller.go 15 19 78.95%
Totals Coverage Status
Change from base Build 6204968357: 0.1%
Covered Lines: 3752
Relevant Lines: 8749

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this @rpemsel!
As we discussed, if service account already exists, controller won't create it.
/assign @tenzen-y @alculquicondor @terrytangyuan
Please take a look.

@alculquicondor
Copy link

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 20, 2023
@johnugeorge
Copy link
Member

johnugeorge commented Sep 20, 2023

/approve

1 similar comment
@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, rpemsel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 288d680 into kubeflow:master Sep 20, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launcher is not started with specified ServiceAccountName
7 participants