-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!chore: Remove support for MXJob #1953
Conversation
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Pull Request Test Coverage Report for Build 7023065747
💛 - Coveralls |
Pull Request Test Coverage Report for Build 7023661984
💛 - Coveralls |
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
This would be a breaking change but I think it's relatively safe given how few people are using MXNet these days. cc @kubeflow/wg-training-leads |
Thank you for creating this @terrytangyuan. I think, we still use MXNet for various things. E.g. this Trial image is the most popular in Katib: https://github.com/kubeflow/katib/tree/master/examples/v1beta1/trial-images/mxnet-mnist Let's discuss it in one of our upcoming WG meetings on how to inform Kubeflow users about it. |
Any concerns of removing this? I don't think we want to continue supporting it. |
Related: #1996. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/remove-lifecycle stale |
Does anyone want to pick this up? |
I don't think I'll have time to complete this. If you are interested in contributing, feel free to start a new PR. |
I can pick up this one. |
Thank you @tariq-hasan! |
Sound good. |
Great. Thanks! |
Unfortunately, Apache MXNet has been archived. This PR removes MXJob support.