Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to create PyTorchJob from func #1979

Merged

Conversation

andreyvelich
Copy link
Member

I added unit test to create PyTorchJob from function.
Also, modified logging level so we can see the E2E results in logs.

/assign @deepak-muley @johnugeorge @droctothorpe

Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: droctothorpe.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

I added unit test to create PyTorchJob from function.
Also, modified logging level so we can see the E2E results in logs.

/assign @deepak-muley @johnugeorge @droctothorpe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Jan 8, 2024

Pull Request Test Coverage Report for Build 7477057367

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 42.896%

Totals Coverage Status
Change from base Build 7423814404: 0.09%
Covered Lines: 3756
Relevant Lines: 8756

💛 - Coveralls

@andreyvelich andreyvelich force-pushed the sdk-test-create-from-func branch from aa5ed2f to 4da6cfc Compare January 8, 2024 14:38
@andreyvelich
Copy link
Member Author

I think, test has been completed.
Please take a look @johnugeorge @droctothorpe @deepak-muley @tenzen-y

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 11, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 37c7fb2 into kubeflow:master Jan 11, 2024
33 checks passed
@andreyvelich andreyvelich deleted the sdk-test-create-from-func branch January 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants