Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] development guide update #1995

Merged

Conversation

shashank-iitbhu
Copy link
Contributor

What this PR does / why we need it:

  • This PR updates the development guide by update the command for installing dependancies to go mod tidy .
  • Also updating the path for the example.

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

/assign @kubeflow/wg-training-leads

@@ -75,7 +75,7 @@ make run
To verify local operator is working, create an example job and you should see jobs created by it.

```sh
cd ./examples/v1/dist-mnist
cd ./examples/tensorflow/dist-mnist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shashank-iitbhu, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7653024732

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 42.885%

Totals Coverage Status
Change from base Build 7573154086: 0.05%
Covered Lines: 3755
Relevant Lines: 8756

💛 - Coveralls

@tenzen-y
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 25, 2024
@google-oss-prow google-oss-prow bot merged commit 98d40be into kubeflow:master Jan 25, 2024
35 checks passed
@shashank-iitbhu shashank-iitbhu deleted the docs/dev-guide-update branch January 25, 2024 14:06
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
* [docs] developer_guide update

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>

* update

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>

---------

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
* [docs] developer_guide update

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>

* update

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>

---------

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants