-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish torchrun example via Dockerfile #2018
publish torchrun example via Dockerfile #2018
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
5e8f9e4
to
59da9ef
Compare
@PeterWrighten: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kubeflow/wg-training-leads Could you approve CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, PeterWrighten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
I wanted to verify it in CI before merging... |
em. I notice it's a simple change and file path are all correct. |
examples/pytorch/cpu-demo/demo.py should resolve the issues. Let's cut a separate PR to fix it..
|
I guess that we need to specify context like this:
|
@tenzen-y Yeah, changing the context works as well. |
Signed-off-by: PeterWrighten <peterwrighten@gmail.com> (cherry picked from commit 6133600)
Signed-off-by: PeterWrighten <peterwrighten@gmail.com> Signed-off-by: deepanker13 <deepanker.gupta@nutanix.com>
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
Signed-off-by: PeterWright peterwrighten@gmail.com
What this PR does / why we need it:
In order to close #2017
Publish torchrun example via DockerRegistry
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #2017
Checklist: