Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build workflow config for pytorch-torchrun-example #2020

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Fix build workflow config for pytorch-torchrun-example #2020

merged 4 commits into from
Mar 9, 2024

Conversation

PeterWrighten
Copy link
Contributor

@PeterWrighten PeterWrighten commented Mar 9, 2024 •
edited
Loading

What this PR does / why we need it:

In order to fix context-specific issue stated in #2019

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2019

Checklist:

  • Docs included if any changes are user facing

@PeterWrighten
publish torchrun example via Dockerfile
59da9ef 
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
@PeterWrighten
fix context error
a5f2ff6 
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
@google-oss-prow google-oss-prow bot requested review from jinchihe and kuizhiqing March 9, 2024 03:22
@coveralls
Copy link

coveralls commented Mar 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8214232180

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 42.885%
Totals Coverage Status
Change from base Build 8210008675: 0.01%
Covered Lines: 3755
Relevant Lines: 8756
💛 - Coveralls

@PeterWrighten
Copy link
Contributor Author

@tenzen-y @Jeffwan I have fixed the issue in this PR.

@PeterWrighten
Copy link
Contributor Author

@kubeflow/wg-training-leads please review~

tenzen-y
tenzen-y reviewed Mar 9, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title with "Fix build workflow config for pytorch-torchrun-example"

.github/workflows/publish-example-images.yaml Outdated Show resolved Hide resolved
@tenzen-y
Copy link
Member

tenzen-y commented Mar 9, 2024

/hold

@PeterWrighten PeterWrighten changed the title Context error Fix build workflow config for pytorch-torchrun-example Mar 9, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Mar 9, 2024

To avoid DCO error, you should add sign "Signed-off-by: PeterWrighten peterwrighten@gmail.com" to 6498013 commit.

@tenzen-y
Copy link
Member

tenzen-y commented Mar 9, 2024

/lgtm
/approve

@tenzen-y
Copy link
Member

tenzen-y commented Mar 9, 2024

To avoid DCO error, you should add sign "Signed-off-by: PeterWrighten peterwrighten@gmail.com" to 6498013 commit.

@PeterWrighten Could you address this?

@PeterWrighten
Copy link
Contributor Author

To avoid DCO error, you should add sign "Signed-off-by: PeterWrighten peterwrighten@gmail.com" to 6498013 commit.

@PeterWrighten Could you address this?

I would do it soon, because I'm on the way to home now. Sorry.

@tenzen-y
Copy link
Member

tenzen-y commented Mar 9, 2024

To avoid DCO error, you should add sign "Signed-off-by: PeterWrighten peterwrighten@gmail.com" to 6498013 commit.

@PeterWrighten Could you address this?

I would do it soon, because I'm on the way to home now. Sorry.

No worries.

@PeterWrighten @tenzen-y
Update publish-example-images.yaml
d9d261c 
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 9, 2024
@PeterWrighten
Copy link
Contributor Author

To avoid DCO error, you should add sign "Signed-off-by: PeterWrighten peterwrighten@gmail.com" to 6498013 commit.

@PeterWrighten Could you address this?

I would do it soon, because I'm on the way to home now. Sorry.

No worries.

Done.

@tenzen-y
Copy link
Member

tenzen-y commented Mar 9, 2024

/lgtm
/approve

/hold cancel

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterWrighten, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 14eeaeb into kubeflow:master Mar 9, 2024
37 checks passed
@PeterWrighten PeterWrighten deleted the context-error branch March 9, 2024 12:06
@tenzen-y
Copy link
Member

tenzen-y commented Mar 9, 2024

Published 🎉

https://hub.docker.com/r/kubeflow/pytorch-torchrun-cpu/tags

tedhtchang pushed a commit to tedhtchang/training-operator that referenced this pull request Apr 5, 2024
@PeterWrighten @tenzen-y @tedhtchang
Fix build workflow config for pytorch-torchrun-example (kubeflow#2020)
d979e7d 
* publish torchrun example via Dockerfile

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

* fix context error

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

* Update publish-example-images.yaml

Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

---------

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
deepanker13 pushed a commit to deepanker13/deepanker-training-operator that referenced this pull request Apr 8, 2024
@PeterWrighten @tenzen-y @deepanker13
Fix build workflow config for pytorch-torchrun-example (kubeflow#2020)
d7d79dc 
* publish torchrun example via Dockerfile

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

* fix context error

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

* Update publish-example-images.yaml

Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

---------

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: deepanker13 <deepanker.gupta@nutanix.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
@PeterWrighten @tenzen-y @johnugeorge
Fix build workflow config for pytorch-torchrun-example (kubeflow#2020)
9ed3f19 
* publish torchrun example via Dockerfile

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

* fix context error

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

* Update publish-example-images.yaml

Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

---------

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
@PeterWrighten @tenzen-y @johnugeorge
Fix build workflow config for pytorch-torchrun-example (kubeflow#2020)
dccfc74 
* publish torchrun example via Dockerfile

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

* fix context error

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

* Update publish-example-images.yaml

Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: PeterWrighten <peterwrighten@gmail.com>

---------

Signed-off-by: PeterWrighten <peterwrighten@gmail.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@tenzen-y tenzen-y

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context Specific Error when publishing examples in docker registry
3 participants
@PeterWrighten @coveralls @tenzen-y