-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake8 linter for Python files in CI/CD #2022
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sandipanpanda The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Check the style and quality of python code using flake8 in CI/CD Signed-off-by: Sandipan Panda <samparksandipan@gmail.com>
34b8e44
to
96381d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @sandipanpanda!
I think the main idea behind this issue #1910 was to add another instruction to the Makefile which will run script from hack
directory (e.g. verify-python.sh
).
This script will use black
and flake8
to check Python code.
So contributors can easily run make fmt-python
.
Does it make sense ?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @sandipanpanda, do you have time to finalize this PR ? |
What this PR does / why we need it:
Check the style and quality of python code using flake8 in CI/CD
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes # #1910