Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade controller-gen to v0.14.0 #2026

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

champon1020
Copy link
Contributor

@champon1020 champon1020 commented Mar 12, 2024

What this PR does / why we need it:
Upgrade controller-gen to v0.14.0, in order to avoid runtime panic when conducting make install with Go 1.22.
(About this problem and solution is mentioned in controller-gen: #888)

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2025

Checklist:

  • Docs included if any changes are user facing

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Thanks!

@kubeflow/wg-training-leads Could you approve CI?

@coveralls
Copy link

coveralls commented Mar 13, 2024

Pull Request Test Coverage Report for Build 8319762885

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 42.873%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
pkg/controller.v1/mpi/mpijob_controller.go 2 81.05%
Totals Coverage Status
Change from base Build 8301378902: -0.04%
Covered Lines: 3754
Relevant Lines: 8756

💛 - Coveralls

@tenzen-y
Copy link
Member

@champon1020 Could you re-generate CRD?

@champon1020
Copy link
Contributor Author

@tenzen-y Now I re-generated CRD by make manifests.

@tenzen-y
Copy link
Member

tenzen-y commented Mar 14, 2024

The building failed due to unintended errors:

#13 126.4 Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
#13 127.4 ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
#13 127.4 unknown package:
#13 127.4 Expected sha256 abad2e08652df153a72177ce20c897d083b0c4ebeec051239e2654ddf4d3c996
#13 127.4 Got 87ed613b5633f5c43e8a3237061548036f19c1e261b78491afa23d7b7ad211a3
#13 127.4
#13 ERROR: process "/bin/sh -c pip install --no-cache-dir -r requirements.txt" did not complete successfully: exit code: 1

https://github.com/kubeflow/training-operator/actions/runs/8282278962/job/22664907995?pr=2026#step:5:1615

@deepanker13 Could you investigate this?

@deepanker13
Copy link
Contributor

The building failed due to unintended errors:

#13 126.4 Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
#13 127.4 ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
#13 127.4 unknown package:
#13 127.4 Expected sha256 abad2e08652df153a72177ce20c897d083b0c4ebeec051239e2654ddf4d3c996
#13 127.4 Got 87ed613b5633f5c43e8a3237061548036f19c1e261b78491afa23d7b7ad211a3
#13 127.4
#13 ERROR: process "/bin/sh -c pip install --no-cache-dir -r requirements.txt" did not complete successfully: exit code: 1

https://github.com/kubernetes-sigs/kueue/blob/975b5f238ee08c27c5988ec46a52ce1f29e38285/test/integration/scheduler/podsready/suite_test.go#L96-L97

@deepanker13 Could you investigate this?

Sure, looking into it

@tenzen-y
Copy link
Member

The building failed due to unintended errors:

#13 126.4 Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
#13 127.4 ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
#13 127.4 unknown package:
#13 127.4 Expected sha256 abad2e08652df153a72177ce20c897d083b0c4ebeec051239e2654ddf4d3c996
#13 127.4 Got 87ed613b5633f5c43e8a3237061548036f19c1e261b78491afa23d7b7ad211a3
#13 127.4
#13 ERROR: process "/bin/sh -c pip install --no-cache-dir -r requirements.txt" did not complete successfully: exit code: 1

https://github.com/kubernetes-sigs/kueue/blob/975b5f238ee08c27c5988ec46a52ce1f29e38285/test/integration/scheduler/podsready/suite_test.go#L96-L97
@deepanker13 Could you investigate this?

Sure, looking into it

Sorry, I put an irrelevant link above. The correctly link is https://github.com/kubeflow/training-operator/actions/runs/8282278962/job/22664907995?pr=2026#step:5:1615

@tenzen-y
Copy link
Member

The building failed due to unintended errors:

#13 126.4 Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
#13 127.4 ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
#13 127.4 unknown package:
#13 127.4 Expected sha256 abad2e08652df153a72177ce20c897d083b0c4ebeec051239e2654ddf4d3c996
#13 127.4 Got 87ed613b5633f5c43e8a3237061548036f19c1e261b78491afa23d7b7ad211a3
#13 127.4
#13 ERROR: process "/bin/sh -c pip install --no-cache-dir -r requirements.txt" did not complete successfully: exit code: 1

https://github.com/kubernetes-sigs/kueue/blob/975b5f238ee08c27c5988ec46a52ce1f29e38285/test/integration/scheduler/podsready/suite_test.go#L96-L97
@deepanker13 Could you investigate this?

Sure, looking into it

Sorry, I put an irrelevant link above. The correctly link is https://github.com/kubeflow/training-operator/actions/runs/8282278962/job/22664907995?pr=2026#step:5:1615

@deepanker13 @champon1020 We will fix the dependencies issue in #2031.
After it is merged, we can merge this into the master branch. Thank you for your patience.

@tenzen-y
Copy link
Member

@champon1020 Could you rebase this PR since we fixed CI issues?

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
Signed-off-by: champon1020 <nagatelu1020@gmail.com>
@tenzen-y
Copy link
Member

@kubeflow/wg-training-leads Could you approve CI?

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for great contribution!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 20, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champon1020, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit b7e0dbc into kubeflow:master Mar 20, 2024
37 checks passed
tedhtchang pushed a commit to tedhtchang/training-operator that referenced this pull request Apr 5, 2024
* fix: upgrade controller-gen to v0.14.0

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

* gen: make manifests to re-generate crd

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

---------

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
deepanker13 pushed a commit to deepanker13/deepanker-training-operator that referenced this pull request Apr 8, 2024
* fix: upgrade controller-gen to v0.14.0

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

* gen: make manifests to re-generate crd

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

---------

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
Signed-off-by: deepanker13 <deepanker.gupta@nutanix.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
* fix: upgrade controller-gen to v0.14.0

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

* gen: make manifests to re-generate crd

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

---------

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
* fix: upgrade controller-gen to v0.14.0

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

* gen: make manifests to re-generate crd

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

---------

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to follow steps in developer_guide.md
4 participants