Support K8s v1.29 and Drop K8s v1.26 #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tenzen-y
force-pushed
the
support-k8s-129
branch
from
9d0f4bf to
503c1c7
Compare
Pull Request Test Coverage Report for Build 8473367682Details
💛 - Coveralls |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
support-k8s-129
branch
from
503c1c7 to
07a4a89
Compare
tenzen-y
commented
Mar 28, 2024
| "k8s.io/utils/pointer" | ||
| "k8s.io/utils/ptr" |
There was a problem hiding this comment.
I addressed the following golangci-lint error:
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
tenzen-y
commented
Mar 28, 2024
Comment on lines
-54
to
+55
| MXJobReplicaTypeWorker: &ReplicaSpec{ | ||
| Replicas: pointer.Int32(replicas), | ||
| MXJobReplicaTypeWorker: { | ||
| Replicas: ptr.To[int32](replicas), |
There was a problem hiding this comment.
I removed the unnecessary type specifying.
|
/lgtm |
tedhtchang
pushed a commit
to tedhtchang/training-operator
that referenced
this pull request
Apr 5, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> (cherry picked from commit fb35949)
deepanker13
pushed a commit
to deepanker13/deepanker-training-operator
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: deepanker13 <deepanker.gupta@nutanix.com>
11 tasks
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I added support for the K8s v1.29 and dropped the K8s v1.26.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #1999
Checklist: