Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dockerfile.ppc64le of pytorch example #2042

Conversation

champon1020
Copy link
Contributor

What this PR does / why we need it:
As mentioned in #2024 (comment) by @tenzen-y, since Dockerfile.ppc64le can be unified to Dockerfile, I remove it.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Related to #2024

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
@coveralls
Copy link

coveralls commented Mar 30, 2024

Pull Request Test Coverage Report for Build 8494206224

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 42.842%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 8493820728: -0.01%
Covered Lines: 3750
Relevant Lines: 8753

💛 - Coveralls

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
@champon1020 champon1020 force-pushed the patch-issue-2016-remove-dockerfile-ppc64le branch from dd31474 to 2d86d8e Compare March 30, 2024 23:59
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champon1020, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a08246d into kubeflow:master Apr 3, 2024
38 of 39 checks passed
deepanker13 pushed a commit to deepanker13/deepanker-training-operator that referenced this pull request Apr 8, 2024
* fix: remove Dockerfile.ppc64le of pytorch example

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

* fix: update README.md

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

---------

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
Signed-off-by: deepanker13 <deepanker.gupta@nutanix.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
* fix: remove Dockerfile.ppc64le of pytorch example

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

* fix: update README.md

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

---------

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
* fix: remove Dockerfile.ppc64le of pytorch example

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

* fix: update README.md

Signed-off-by: champon1020 <nagatelu1020@gmail.com>

---------

Signed-off-by: champon1020 <nagatelu1020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants