-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: upgrade version of crd-ref-docs, which caused panic with go v1.22 #2043
Fix: upgrade version of crd-ref-docs, which caused panic with go v1.22 #2043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating this PR!
@jdcfd Once you re-generate docs in your local, are there any changes?
Pull Request Test Coverage Report for Build 8578297700Details
💛 - Coveralls |
Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com>
d9a1450
to
1f566c8
Compare
Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com>
1f566c8
to
93320d0
Compare
Hi @tenzen-y , sorry for the delayed response. I added the new asciidoc file that was generated by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdcfd Thank you for this update!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jdcfd, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeflow#2043) * Fix: upgrade version of crd-ref-docs, which caused panic with go v1.22 Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com> * added generated api doc Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com> --------- Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com>
kubeflow#2043) * Fix: upgrade version of crd-ref-docs, which caused panic with go v1.22 Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com> * added generated api doc Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com> --------- Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com>
What this PR does / why we need it:
Upgrade version of crd-ref-docs v0.0.8 -> v0.0.11. Default version causes panic with Go v1.22. This issue might prevent new developers from contributing to the project.
Which issue(s) this PR fixes:
Fixes #2025 .
Checklist: