Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sdk to v1.8.0rc0 #2087

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Update sdk to v1.8.0rc0 #2087

merged 1 commit into from
Apr 28, 2024

Conversation

johnugeorge
Copy link
Member

The 1.8 release branch is created and SDK 1.8 rc0 is cut

@coveralls
Copy link

coveralls commented Apr 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8867563407

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 35.439%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 8867374187: 0.02%
Covered Lines: 4381
Relevant Lines: 12362
💛 - Coveralls

@johnugeorge
Update sdk to v1.8.0rc0
b9d700c 
Signed-off-by: Johnu George <johnugeorge109@gmail.com>
andreyvelich
andreyvelich approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @johnugeorge!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Apr 28, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0d8fa74 into kubeflow:v1.8-branch Apr 28, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@andreyvelich andreyvelich

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnugeorge @coveralls @andreyvelich