Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isort on examples/pytorch #2094

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

marcmaliar
Copy link
Contributor

What this PR does / why we need it:

Python imports are out of order in examples/pytorch.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): NA

Copy link

google-cla bot commented May 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Marc Maliar <marc.maliar77@gmail.com>
Co-authored-by: Jocelyn Huang <jocelynYH4@gmail.com>
Co-authored-by: Andreas Loutzidis <aloutzidis@gmail.com>
Co-authored-by: Akshay Gupta <akshaygupta.us@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8931938526

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 35.415%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 81.05%
Totals Coverage Status
Change from base Build 8854426275: -0.02%
Covered Lines: 4378
Relevant Lines: 12362

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change!

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, marcmaliar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f23c5c8 into kubeflow:master May 3, 2024
39 checks passed
anindyahepth pushed a commit to anindyahepth/training-operator that referenced this pull request May 3, 2024
Signed-off-by: Marc Maliar <marc.maliar77@gmail.com>
Co-authored-by: Jocelyn Huang <jocelynYH4@gmail.com>
Co-authored-by: Andreas Loutzidis <aloutzidis@gmail.com>
Co-authored-by: Akshay Gupta <akshaygupta.us@gmail.com>
Signed-off-by: Anindya Dey <anindyadey@Techs-Air-2.verizon.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants