Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed import sort order on api_client.py using isort #2100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed import sort order on api_client.py using isort #2100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
246dd0e
fixed import sort order on api_client.py
May 2, 2024
ff2c17a
Fix isort on examples/pytorch (#2094)
marcmaliar May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/pytorch/cpu-demo/demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import torch

torch.distributed.init_process_group(init_method="env://")
rank = torch.distributed.get_rank()
world_size = torch.distributed.get_world_size()
Expand Down
1 change: 0 additions & 1 deletion examples/pytorch/elastic/echo/echo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import torch.distributed as dist


if __name__ == "__main__":

env_dict = {
Expand Down
13 changes: 6 additions & 7 deletions sdk/python/kubeflow/training/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,21 @@

import atexit
import datetime
from dateutil.parser import parse
import json
import mimetypes
from multiprocessing.pool import ThreadPool
import os
import re
import tempfile
from multiprocessing.pool import ThreadPool

import kubeflow.training.models
# python 2 and python 3 compatibility library
import six
from six.moves.urllib.parse import quote

from kubeflow.training.configuration import Configuration
import kubeflow.training.models
from dateutil.parser import parse
from kubeflow.training import rest
from kubeflow.training.exceptions import ApiValueError, ApiException
from kubeflow.training.configuration import Configuration
from kubeflow.training.exceptions import ApiException, ApiValueError
from six.moves.urllib.parse import quote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you remove changes from api_client.py file since this file is generated automatically by CODE_GEN: https://github.com/kubeflow/training-operator/blob/master/hack/python-sdk/gen-sdk.sh#L48.



class ApiClient(object):
Expand Down