Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release document #2153

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

andreyvelich
Copy link
Member

I updated the release document.
Eventually, we should automate the release process for Training Operator.

I will create separate issue to track release improvements that we need to follow for Training Operator.

/assign @kubeflow/wg-training-leads

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9666312688

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 35.39%

Totals Coverage Status
Change from base Build 9543811102: 0.03%
Covered Lines: 4376
Relevant Lines: 12365

💛 - Coveralls

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9666410579

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 35.423%

Totals Coverage Status
Change from base Build 9543811102: 0.07%
Covered Lines: 4380
Relevant Lines: 12365

💛 - Coveralls

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9666507304

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 35.398%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 9543811102: 0.04%
Covered Lines: 4377
Relevant Lines: 12365

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2b39d3c into kubeflow:master Jun 26, 2024
39 checks passed
@andreyvelich andreyvelich deleted the update-release-doc branch June 26, 2024 07:42
YosiElias pushed a commit to YosiElias/training-operator that referenced this pull request Jul 18, 2024
* Update release document

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add twine command

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Explain image publishing

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add link to the overlays

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Fix format

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Fix git push command

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

---------

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants