[SDK] Fix Failed condition in wait Job API #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9892496393Details
💛 - Coveralls |
15 tasks
tenzen-y
reviewed
Jul 10, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
andreyvelich
force-pushed
the
sdk-fix-failed-condition
branch
from
8909f2b
to
09ba2d1
Compare
Sure, done |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andreyvelich
added a commit
to andreyvelich/training-operator
that referenced
this pull request
Jul 11, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
YosiElias
pushed a commit
to YosiElias/training-operator
that referenced
this pull request
Jul 18, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: yelias <yossi.elias@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check if Failed is not in
expected_conditionsset. We need to add more unit tests for our SDK. I will create issues for it./assign @kubeflow/wg-training-leads @droctothorpe