Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JAX integration proposal #2165

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

sandipanpanda
Copy link
Contributor

What this PR does / why we need it:
A separate Coordinator replica for JAX is not needed, since Pod template will be the same and Worker with process_id 0 will act as the Coordinator.

Signed-off-by: Sandipan Panda <samparksandipan@gmail.com>
@sandipanpanda
Copy link
Contributor Author

/cc @andreyvelich @tenzen-y
/area gsoc

@andreyvelich
Copy link
Member

Related: #2145

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this @sandipanpanda!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ee736a7 into kubeflow:master Jul 15, 2024
39 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9913473227

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 35.406%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 81.05%
Totals Coverage Status
Change from base Build 9906458669: -0.02%
Covered Lines: 4378
Relevant Lines: 12365

💛 - Coveralls

@sandipanpanda sandipanpanda deleted the update-jax-proposal branch July 16, 2024 19:57
YosiElias pushed a commit to YosiElias/training-operator that referenced this pull request Jul 18, 2024
Signed-off-by: Sandipan Panda <samparksandipan@gmail.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants