Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the server-side apply installation args #2337

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Refine the server-side apply installation args #2337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ docker-push: ## Push docker image with the manager.
##@ Deployment

install: manifests kustomize ## Install CRDs into the K8s cluster specified in ~/.kube/config.
$(KUSTOMIZE) build manifests/base/crds | kubectl apply --server-side=true -f -
$(KUSTOMIZE) build manifests/base/crds | kubectl apply --server-side -f -

uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified in ~/.kube/config.
$(KUSTOMIZE) build manifests/base/crds | kubectl delete -f -
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ for the detailed instructions on how to install Training Operator.
Run the following command to install the latest stable release of the Training Operator control plane: `v1.8.0`.

```bash
kubectl apply --server-side=true -k "github.com/kubeflow/training-operator.git/manifests/overlays/standalone?ref=v1.8.0"
kubectl apply --server-side -k "github.com/kubeflow/training-operator.git/manifests/overlays/standalone?ref=v1.8.0"
```

Run the following command to install the latest changes of the Training Operator control plane:

```bash
kubectl apply --server-side=true -k "github.com/kubeflow/training-operator/manifests/overlays/standalone"
kubectl apply --server-side -k "github.com/kubeflow/training-operator/manifests/overlays/standalone"
```

### Installing the Python SDK
Expand Down
2 changes: 1 addition & 1 deletion scripts/gha/setup-training-operator.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ cd manifests/overlays/standalone
kustomize edit set image kubeflow/training-operator=${TRAINING_CI_IMAGE}

echo "Installing training operator manifests"
kustomize build . | kubectl apply --server-side=true -f -
kustomize build . | kubectl apply --server-side -f -

if [ "${GANG_SCHEDULER_NAME}" = "scheduler-plugins" ]; then
SCHEDULER_PLUGINS_VERSION=$(go list -m -f "{{.Version}}" sigs.k8s.io/scheduler-plugins)
Expand Down
2 changes: 1 addition & 1 deletion scripts/setup-training-operator.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ cd manifests/overlays/standalone
kustomize edit set image kubeflow/training-operator=${REGISTRY}:${VERSION}

echo "Installing training operator manifests"
kustomize build . | kubectl apply --server-side=true -f -
kustomize build . | kubectl apply --server-side -f -

TIMEOUT=30
until kubectl get pods -n kubeflow | grep training-operator | grep 1/1 || [[ $TIMEOUT -eq 1 ]]; do
Expand Down
Loading