api: OpenAPI support #577
api: OpenAPI support #577
Conversation
|
It seems that I misunderstand the meaning of the beta feature We could use OpenAPI to generate clients for all languages to allow users to CRUD tfjob in all languages. While the feature Here is the logic, and we do not need to have a OpenAPI spec for the feature. @jlewi Do you think we need to |
|
I think we want the API server to validate the config.
Language clients might be nice at some point but I think it's P2.
…On Wed, May 9, 2018, 1:37 AM Ce Gao ***@***.***> wrote:
It seems that I misunderstand the meaning of the beta feature
CustomResourceValidation. We do not have to generate/serve open api spec
to use the feature.
We could use OpenAPI to generate clients for all languages to allow users
to CRUD tfjob in all languages. While the feature CustomResourceValidation
is to let the API server to use `` to validate the config.
Here
<https://github.com/kubernetes/kubernetes/blob/f49f799dbda6ce47d5d5709b73bede68d3ccde0f/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/validation.go#L32>
is the logic, and we do not need to have a OpenAPI spec for the feature.
@jlewi <https://github.com/jlewi> Do you think we need to generate
clients for all languages to allow users to CRUD tfjob in all languages?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#577 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAvcA4vUM_gQY_t6SsUHKq5m85mqtrdCks5twqrKgaJpZM4T34oJ>
.
|
|
SGTM |
|
I am trying to generate crd validation with the support of https://github.com/ant31/crd-validation, and we need the openapi_generated.go in this PR for the generation. Therefore PTAL. |
|
/assign @ScorpioCPH @jlewi |
|
It is not urgent anymore since we know that it is not practical to use crd validation feature to validate all types in the CRD. I am switching to the way described in #561 (comment) |
|
/lgtm Looks like we might need to manually merge though since coveralls test is busted by all the generated code. @gaocegege Is this ready to merge? |
|
I will try to add ignore for the coverage test. |
|
/retest |
1 similar comment
|
/retest |
|
PTAL again @jlewi |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold I prefer to merge #610 first since this PR may have conflicts with it. |
|
/hold cancel I will fix the conflicts asap. |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
New changes are detected. LGTM label has been removed. |
|
Rebasing upstream/master, thus no need to review again. |
* hack: Add openapi-gen Signed-off-by: Ce Gao <gaoce@caicloud.io> * api: Generate openapi model Signed-off-by: Ce Gao <gaoce@caicloud.io> * linter_config: Add Signed-off-by: Ce Gao <gaoce@caicloud.io> * openapi: Add k8s.io Signed-off-by: Ce Gao <gaoce@caicloud.io> * .travis: Ignore openapi Signed-off-by: Ce Gao <gaoce@caicloud.io> * dep: Update Signed-off-by: Ce Gao <gaoce@caicloud.io>
* hack: Add openapi-gen Signed-off-by: Ce Gao <gaoce@caicloud.io> * api: Generate openapi model Signed-off-by: Ce Gao <gaoce@caicloud.io> * linter_config: Add Signed-off-by: Ce Gao <gaoce@caicloud.io> * openapi: Add k8s.io Signed-off-by: Ce Gao <gaoce@caicloud.io> * .travis: Ignore openapi Signed-off-by: Ce Gao <gaoce@caicloud.io> * dep: Update Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao gaoce@caicloud.io
This change is