-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Generate OpenAPI specification for Java, Python client #719
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Thanks for your awesome contribution! Could you please sign the CLA BTW, do you run |
@gaocegege there are still some problems on dependencies, I'm working on it now.. |
@jetmuffin Gotcha Feel free to @ me if you meet problems. |
/ok-to-test |
Travis tests have failedHey @jetmuffin, 1st Buildgometalinter --config=linter_config.json --vendor ./...
3rd Buildgometalinter --config=linter_config.json --vendor ./...
|
Travis tests have failedHey @jetmuffin, 1st Buildgometalinter --config=linter_config.json --vendor ./...
3rd Buildgometalinter --config=linter_config.json --vendor ./...
|
We could add hack as ignore files for gometalinter in Travis CI, because it is not the code used by the operator. |
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Hi, any progress? |
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
CLAs look good, thanks! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @ddysher |
@gaocegege I tried to reduce the size of vendor, but it seems necessary to set up a server with generated model and api routing information according to kubernetes/kube-openapi#13, so many packages of |
@jetmuffin Thanks, we could keep it if it is necessary. @ddysher We have a discussion about whether the code should be in the upstream, so PTAL. |
Travis tests have failedHey @jetmuffin, 1st Buildgometalinter --config=linter_config.json --vendor ./...
|
After discussion with @gaocegege , we plan to move this generator to kubeflow-incubator/genspec due to the huge size of vendors. /close |
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)