Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Generate OpenAPI specification for Java, Python client #719

Closed
wants to merge 6 commits into from

Conversation

jetmuffin
Copy link
Contributor

@jetmuffin jetmuffin commented Jul 9, 2018

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jetmuffin jetmuffin changed the title Generate OpenAPI specification for Java, Python client WIP: Generate OpenAPI specification for Java, Python client Jul 9, 2018
@gaocegege
Copy link
Member

Thanks for your awesome contribution!

Could you please sign the CLA

BTW, do you run dep prune to reduce the size of vendor?

@jetmuffin
Copy link
Contributor Author

@gaocegege there are still some problems on dependencies, I'm working on it now..

@gaocegege
Copy link
Member

@jetmuffin Gotcha

Feel free to @ me if you meet problems.

@gaocegege
Copy link
Member

/ok-to-test

@TravisBuddy
Copy link

Travis tests have failed

Hey @jetmuffin,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

gometalinter --config=linter_config.json --vendor ./...
hack/genspec/genspec.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: unused variable or constant cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm (varcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get (unconvert)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd (unconvert)
hack/genspec/genspec.go:69::warning: Expect directory permissions to be 0700 or less,MEDIUM,HIGH (gas)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: unused variable or constant cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: error return value not checked (cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm) (errcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: unused variable or constant cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable (unconvert)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: error return value not checked (cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: unused variable or constant cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact (unconvert)
pkg/apis/tensorflow/v1alpha2/install.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: error return value not checked (cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant) (errcheck)
hack/genspec/lib/lister_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/std_storage.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: unused variable or constant cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd (varcheck)
hack/genspec/lib/cd_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/rd_storage.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm (unconvert)
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: unused variable or constant cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: unused variable or constant cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant (unconvert)
hack/genspec/lib/getter_storage.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: error return value not checked (cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: error return value not checked (cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: error return value not checked (cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable) (errcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata (gosimple, staticcheck, unconvert)
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: error return value not checked (cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata) (errcheck)

3rd Build

gometalinter --config=linter_config.json --vendor ./...
hack/genspec/lib/lister_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/rd_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/std_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/genspec.go:69::warning: Expect directory permissions to be 0700 or less,MEDIUM,HIGH (gas)
pkg/apis/tensorflow/v1alpha2/install.go:12:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
hack/genspec/genspec.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/getter_storage.go:1::warning: file is not goimported (goimports)
pkg/apis/tensorflow/v1alpha2/install.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/cd_storage.go:1::warning: file is not goimported (goimports)

travis_time:end:103f4e92:start=1531107265293697385,finish=1531107652229901481,duration=386936204096

@coveralls
Copy link

coveralls commented Jul 9, 2018

Coverage Status

Coverage decreased (-0.2%) to 57.567% when pulling fa0b965 on JetMuffin:client into 7ebe995 on kubeflow:master.

@TravisBuddy
Copy link

Travis tests have failed

Hey @jetmuffin,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

gometalinter --config=linter_config.json --vendor ./...
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: unused variable or constant cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata (varcheck)
hack/genspec/lib/lister_storage.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: error return value not checked (cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: error return value not checked (cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: error return value not checked (cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable) (errcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata (gosimple, staticcheck, unconvert)
hack/genspec/lib/getter_storage.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: unused variable or constant cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: unused variable or constant cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant (varcheck)
hack/genspec/lib/cd_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/std_storage.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: unused variable or constant cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: error return value not checked (cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: unused variable or constant cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm (unconvert)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable (unconvert)
hack/genspec/genspec.go:69::warning: Expect directory permissions to be 0700 or less,MEDIUM,HIGH (gas)
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: error return value not checked (cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata) (errcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get (unconvert)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: unused variable or constant cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant (unconvert)
hack/genspec/genspec.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd (unconvert)
pkg/apis/tensorflow/v1alpha2/install.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: unused variable or constant cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact (unconvert)
hack/genspec/lib/rd_storage.go:1::warning: file is not goimported (goimports)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: error return value not checked (cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: error return value not checked (cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm) (errcheck)

3rd Build

gometalinter --config=linter_config.json --vendor ./...
hack/genspec/genspec.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/cd_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/getter_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/lister_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/lib/rd_storage.go:1::warning: file is not goimported (goimports)
hack/genspec/genspec.go:69::warning: Expect directory permissions to be 0700 or less,MEDIUM,HIGH (gas)
pkg/apis/tensorflow/v1alpha2/install.go:1::warning: file is not goimported (goimports)
pkg/apis/tensorflow/v1alpha2/install.go:12:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
hack/genspec/lib/std_storage.go:1::warning: file is not goimported (goimports)

travis_time:end:204835cb:start=1531107829372566842,finish=1531108035352905196,duration=205980338354

@gaocegege
Copy link
Member

We could add hack as ignore files for gometalinter in Travis CI, because it is not the code used by the operator.

Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
@gaocegege
Copy link
Member

Hi, any progress?

Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
@googlebot
Copy link

CLAs look good, thanks!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wbuchwalter

If they are not already assigned, you can assign the PR to them by writing /assign @wbuchwalter in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/assign @ddysher

@jetmuffin
Copy link
Contributor Author

jetmuffin commented Jul 11, 2018

@gaocegege I tried to reduce the size of vendor, but it seems necessary to set up a server with generated model and api routing information according to kubernetes/kube-openapi#13, so many packages of k8s.io/apiserver are required.

@gaocegege
Copy link
Member

@jetmuffin Thanks, we could keep it if it is necessary.

@ddysher We have a discussion about whether the code should be in the upstream, so PTAL.

@kubeflow kubeflow deleted a comment from TravisBuddy Jul 11, 2018
@TravisBuddy
Copy link

Travis tests have failed

Hey @jetmuffin,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

gometalinter --config=linter_config.json --vendor ./...
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: unused variable or constant cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm (varcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: error return value not checked (cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: error return value not checked (cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm) (errcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata (gosimple, staticcheck, unconvert)
vendor/github.com/coreos/etcd/clientv3/retry.go:295:9:warning: cannot use &(retryMaintenanceClient literal) (value of type *retryMaintenanceClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.MaintenanceClient value in return statement: wrong type for method Alarm (unconvert)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: unused variable or constant cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: error return value not checked (cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: error return value not checked (cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd) (errcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get (unconvert)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable (unconvert)
vendor/github.com/coreos/etcd/clientv3/client.go:346:51:warning: unused variable or constant cannot use c.tokenCred (variable of type *authTokenCredential) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc/credentials.PerRPCCredentials value in argument to grpc.WithPerRPCCredentials: wrong type for method GetRequestMetadata (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: unused variable or constant cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable (varcheck)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: error return value not checked (cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:364:9:warning: error return value not checked (cannot use &(retryAuthClient literal) (value of type *retryAuthClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.AuthClient value in return statement: wrong type for method AuthDisable) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant (unconvert)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd (unconvert)
vendor/github.com/coreos/etcd/clientv3/retry.go:250:9:warning: unused variable or constant cannot use &(retryClusterClient literal) (value of type *retryClusterClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.ClusterClient value in return statement: wrong type for method MemberAdd (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: error return value not checked (cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant) (errcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:143:9:warning: cannot use &(retryKVClient literal) (value of type *retryKVClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.KVClient value in return statement: wrong type for method Compact (unconvert)
vendor/github.com/coreos/etcd/clientv3/client.go:421:63:warning: unused variable or constant cannot use client.balancer (variable of type *healthBalancer) as github.com/kubeflow/tf-operator/vendor/google.golang.org/grpc.Balancer value in argument to grpc.WithBalancer: wrong type for method Get (varcheck)
vendor/github.com/coreos/etcd/clientv3/retry.go:196:9:warning: unused variable or constant cannot use &(retryLeaseClient literal) (value of type *retryLeaseClient) as github.com/kubeflow/tf-operator/vendor/github.com/coreos/etcd/etcdserver/etcdserverpb.LeaseClient value in return statement: wrong type for method LeaseGrant (varcheck)

@jetmuffin
Copy link
Contributor Author

After discussion with @gaocegege , we plan to move this generator to kubeflow-incubator/genspec due to the huge size of vendors.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants