sdk: add dsl.OneOf docs #3605
sdk: add dsl.OneOf docs #3605
Conversation
|
/hold |
|
/remove-approve |
connor-mccarthy
force-pushed
the
add-dsl-oneof-docs
branch
from
feaf139 to
fd31614
Compare
|
/assign @chensun |
|
|
||
| You should provide task outputs to the `dsl.OneOf` using `.output` or `.outputs[<key>]`, just as you would pass an output to a downstream task. The outputs provided to `dsl.OneOf` must be of the same type and cannot be other instances of `dsl.OneOf` or [`dsl.Collected`][dsl-collected]. | ||
|
|
||
| {{% oss-be-unsupported feature_name="`dsl.OneOf`" %}} |
There was a problem hiding this comment.
We should be consistent on where to put this note.
For features listed in this page, dsl.OneOf has it at the bottom, dsl.ParallelFor has it in the middle, and dsl.Collected has it at the top.
There was a problem hiding this comment.
Thanks for catching that. Moved them all to the bottom.
Reason for bottom: One of the notices is about the parallelism setting on dsl.ParallelFor, which doesn't make sense to put at the top before the parallelism setting has been introduced. Between putting at the bottom and at various places in the middle, I prefer putting everything at the bottom since it invites more uniformity.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
No description provided.