Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block web crawlers on v0.7-branch #3852

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Sep 4, 2024

Google keeps surfacing links from very old versions of the Kubeflow docs website, which is confusing to users.

This PR adds the <meta name="robots" content="noindex"> meta tag to tell Google to stop indexing the pages from the v0.7-branch branch.

It will take probably a few months (or longer) for Google to re-index these pages, I have left nofollow off, so that google will re-index the whole site quicker by following links.


It also backports the changes from #3863 so the version selector is consistent across each archive version.

And updates the OWNERS file of this very old branch to align with the current OWNERS in master to make it easier to approve PRs in the future without GitHub admin overrides.

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper
Copy link
Member Author

The build is actually succeeding on this one, it's just that there is a random other Netlify build which is failing.

The only one that matters is the main one, so this can be merged.

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@james-jwu
Copy link

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: james-jwu
Once this PR has been reviewed and has the lgtm label, please assign gaoning777 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Sep 6, 2024

/lgtm

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Sep 6, 2024
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Sep 6, 2024
@james-jwu james-jwu merged commit 83ec36f into kubeflow:v0.7-branch Sep 12, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants