Add v1 controller/APIs and support multi-version #82
Conversation
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
|
This change is |
terrytangyuan
changed the title
| package v1 | ||
|
|
||
| import ( | ||
| v1 "github.com/kubeflow/common/job_controller/api/v1" |
There was a problem hiding this comment.
Great. It's good to keep on old version and we can upgrade it in separate PR.
| @@ -20,7 +20,7 @@ import ( | |||
| "os" | |||
|
|
|||
| "github.com/kubeflow/xgboost-operator/pkg/apis" | |||
| "github.com/kubeflow/xgboost-operator/pkg/controller" | |||
| controller "github.com/kubeflow/xgboost-operator/pkg/controller/v1" | |||
There was a problem hiding this comment.
This means the master will point to v1 changes. This is expected, right?
There was a problem hiding this comment.
Yes. This is intended so more users would start testing v1 by default.
|
Can you check if Makefile is still working? It pass CI and I think there's no more changes needed on ./travis.yaml |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: merlintang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Jeffwan Yes, I think Makefile still needs some updates. For example, |
Fixes #72.
/cc @merlintang @Jeffwan
Signed-off-by: terrytangyuan terrytangyuan@gmail.com