fix kube-ovn-controller crash on startup (#2305)

kubeovn · Feb 8, 2023 · cd3c333 · cd3c333
1 parent 8c4b917
commit cd3c333
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/pkg/controller/network_policy.go b/pkg/controller/network_policy.go
@@ -788,8 +788,20 @@ func isSvcMatchPod(svc *corev1.Service, pod *corev1.Pod) (bool, error) {
 }
 
 func (c *Controller) podMatchNetworkPolicies(pod *corev1.Pod) []string {
-	podNs, _ := c.namespacesLister.Get(pod.Namespace)
-	nps, _ := c.npsLister.NetworkPolicies(corev1.NamespaceAll).List(labels.Everything())
+	podNs, err := c.namespacesLister.Get(pod.Namespace)
+	if err != nil {
+		klog.Errorf("failed to get namespace %s: %v", pod.Namespace, err)
+		utilruntime.HandleError(err)
+		return nil
+	}
+
+	nps, err := c.npsLister.NetworkPolicies(corev1.NamespaceAll).List(labels.Everything())
+	if err != nil {
+		klog.Errorf("failed to list network policies: %v", err)
+		utilruntime.HandleError(err)
+		return nil
+	}
+
 	match := []string{}
 	for _, np := range nps {
 		if isPodMatchNetworkPolicy(pod, *podNs, np, np.Namespace) {