delete nc cmd in image #2148
Merged
delete nc cmd in image #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
requested changes
Dec 12, 2022
| @@ -9,6 +9,9 @@ COPY grace_stop_ovn_controller /usr/share/ovn/scripts/grace_stop_ovn_controller | |||
|
|
|||
| WORKDIR /kube-ovn | |||
|
|
|||
| RUN rm -f /usr/bin/nc &&\ | |||
There was a problem hiding this comment.
we should remove ncat from base
There was a problem hiding this comment.
Yes. The nc cmd is installed in nmap packet, so I delete the nmap packet in the last PR #2141
But the nc cmd still exists because the ncat is installed in dockerfile.base.
The jira about security only reports cmd about nc and netcat, both are soft link from ncat.
So if we can keep ncat and delete the soft link cmd? It will be convennient if we want to use nc in the pod.
Or It's better to delete ncat totally?
oilbeater
approved these changes
Dec 12, 2022
hongzhen-ma
added a commit
that referenced
this pull request
Dec 12, 2022
hongzhen-ma
added a commit
that referenced
this pull request
Dec 12, 2022
|
已回合 release-1.10 和 release-1.9 分支 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #(issue-number)