Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mem leak in ipam #2566

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: mem leak in ipam #2566

merged 1 commit into from
Mar 29, 2023

Conversation

oilbeater
Copy link
Collaborator

When all nics are popped from the list the map key still exist which will lead memory leak each time a pod is deleted.

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #(issue-number)

@oilbeater oilbeater added the bug Something isn't working label Mar 28, 2023
@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and specific. For example, "Fix memory leak in IPAM caused by leftover map keys" would be better.
  • There are no potential bugs or format errors in the patch.
  • The performance of the code is not affected by this change.
  • One way to improve the code further would be to add comments explaining the purpose of the functions and variables used in the code.

@oilbeater
fix: memory leak in IPAM caused by leftover map keys
c05f86a 
When all nics are popped from the list the map key still exist which will lead memory leak each time a pod is deleted.
@github-actions
Copy link
Contributor

  • The commit message should be more descriptive and provide more context about the changes made.

@oilbeater oilbeater merged commit 3f7997b into master Mar 29, 2023
@oilbeater oilbeater deleted the fix/mem-leak branch March 29, 2023 01:27
oilbeater added a commit that referenced this pull request Mar 29, 2023
@oilbeater
fix: memory leak in IPAM caused by leftover map keys (#2566)
b366ee8 
When all nics are popped from the list the map key still exist which will lead memory leak each time a pod is deleted.

(cherry picked from commit 3f7997b)
oilbeater added a commit that referenced this pull request Mar 29, 2023
@oilbeater
fix: memory leak in IPAM caused by leftover map keys (#2566)
7bdc482 
When all nics are popped from the list the map key still exist which will lead memory leak each time a pod is deleted.

(cherry picked from commit 3f7997b)
oilbeater added a commit that referenced this pull request Mar 29, 2023
@oilbeater
fix: memory leak in IPAM caused by leftover map keys (#2566)
fb70f93 
When all nics are popped from the list the map key still exist which will lead memory leak each time a pod is deleted.

(cherry picked from commit 3f7997b)
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Apr 8, 2023
@zhangzujian
Revert "fix: memory leak in IPAM caused by leftover map keys (kubeovn…
b5d6356 
…#2566)"

This reverts commit 3f7997b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changluyi changluyi changluyi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oilbeater @changluyi