sync subnet to vpc while switching between custom VPC and default VPC #3218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at 8432a48
Refactor and improve subnet and VPC controller logic. Use constants for annotation keys and handle subnet VPC changes and annotations in
subnet.go
. Follow Go naming and style conventions insubnet.go
andvpc.go
.🤖 Generated by Copilot at 8432a48
HOW
🤖 Generated by Copilot at 8432a48
usingIPs
variable inpkg/controller/subnet.go
(link)pkg/controller/subnet.go
(link, link, link)pkg/controller/subnet.go
(link, link, link, link, link, link, link, link, link, link, link, link, link, link)util.VpcLastName
annotation on subnet objects to record and validate the previous VPC name of the subnet inpkg/controller/subnet.go
(link, link, link)pkg/controller/subnet.go
(link)util.VpcLastPolicies
for readability and maintainability inpkg/controller/vpc.go
(link, link)util.VpcLastName
andutil.VpcLastPolicies
to the packageutil
inpkg/util/const.go
(link)