Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slice init length #4579

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: fix slice init length #4579

merged 1 commit into from
Oct 8, 2024

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Oct 4, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

The intention here should be to initialize a slice with a capacity of length rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Which issue(s) this PR fixes

Fixes #(issue-number)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working go Pull requests that update Go code labels Oct 4, 2024
@zhangzujian zhangzujian added need backport test automation tests and removed bug Something isn't working need backport labels Oct 8, 2024
@oilbeater
Copy link
Collaborator

@cuishuang please fix the DCO

Signed-off-by: cuishuang <imcusg@gmail.com>
@cuishuang
Copy link
Contributor Author

@cuishuang please fix the DCO

Modified. Please review again.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@zhangzujian zhangzujian merged commit 4d5cdc7 into kubeovn:master Oct 8, 2024
61 of 62 checks passed
bobz965 pushed a commit that referenced this pull request Oct 25, 2024
Signed-off-by: cuishuang <imcusg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. test automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants