-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: VPC Egress Gateway #4692
base: master
Are you sure you want to change the base?
Conversation
e11c328
to
181d247
Compare
3d22be3
to
4c7dc78
Compare
would there be the possibility to have more than one egress gw? for instance we may want to select different egress gw IPs for different workload in order to filter on a firewall/router |
f67efc2
to
cedc9d6
Compare
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
That's exactly why we introduce this new feature. |
@@ -319,6 +330,7 @@ func Run(ctx context.Context, config *Configuration) { | |||
nodeInformer := informerFactory.Core().V1().Nodes() | |||
serviceInformer := informerFactory.Core().V1().Services() | |||
endpointInformer := informerFactory.Core().V1().Endpoints() | |||
deploymentInformer := informerFactory.Apps().V1().Deployments() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最好能过滤一下,避免不必要的内存开销
"github.com/kubeovn/kube-ovn/pkg/request" | ||
) | ||
|
||
type PodRoutes map[string]map[string][]string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
定义一个新的结构?这个嵌套定义看起来太复杂了
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)