Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: VPC Egress Gateway #4692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@zhangzujian zhangzujian changed the title vpc-nat-gateway: ECMP HA mode [WIP] VPC Egress Gateway Nov 4, 2024
@zhangzujian zhangzujian changed the title [WIP] VPC Egress Gateway feature: VPC Egress Gateway Nov 13, 2024
@patriziobassi
Copy link

would there be the possibility to have more than one egress gw? for instance we may want to select different egress gw IPs for different workload in order to filter on a firewall/router

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
@zhangzujian
Copy link
Member Author

would there be the possibility to have more than one egress gw? for instance we may want to select different egress gw IPs for different workload in order to filter on a firewall/router

That's exactly why we introduce this new feature.

@zhangzujian zhangzujian marked this pull request as ready for review November 25, 2024 09:47
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 25, 2024
@dosubot dosubot bot added feature New network feature vpc labels Nov 25, 2024
@zhangzujian zhangzujian added vpc and removed vpc labels Nov 25, 2024
@@ -319,6 +330,7 @@ func Run(ctx context.Context, config *Configuration) {
nodeInformer := informerFactory.Core().V1().Nodes()
serviceInformer := informerFactory.Core().V1().Services()
endpointInformer := informerFactory.Core().V1().Endpoints()
deploymentInformer := informerFactory.Apps().V1().Deployments()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最好能过滤一下,避免不必要的内存开销

"github.com/kubeovn/kube-ovn/pkg/request"
)

type PodRoutes map[string]map[string][]string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

定义一个新的结构?这个嵌套定义看起来太复杂了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New network feature size:XXL This PR changes 1000+ lines, ignoring generated files. vpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants