Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hostNetwork option #16

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Add hostNetwork option #16

merged 1 commit into from
Oct 29, 2022

Conversation

timo-42
Copy link

@timo-42 timo-42 commented Oct 21, 2022

No description provided.

@timo-42 timo-42 force-pushed the hostnetwork branch 2 times, most recently from 14fdffb to ca59d1e Compare October 21, 2022 21:25
ckotzbauer
ckotzbauer requested changes Oct 22, 2022
View reviewed changes
Copy link
Member

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @timo-haas-by,
thanks for your PR.
Can you please change/add the following things:

  • Increase the "version" field of the Chart.yaml by patch- or minor-level
  • Add the new property to the Chart's README table.

@timo-42 timo-42 force-pushed the hostnetwork branch 2 times, most recently from ef89010 to 5c571e7 Compare October 22, 2022 09:48
@timo-42
Add hostNetwork option
ade6864 
Signed-off-by: Timo Haas <haastimo@gmx.de>
@timo-42
Copy link
Author

timo-42 commented Oct 28, 2022

@ckotzbauer Is there something else todo?

ckotzbauer
ckotzbauer approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No 😉

@ckotzbauer ckotzbauer merged commit 701dc1c into kubereboot:main Oct 29, 2022
@hairmare hairmare mentioned this pull request Nov 23, 2022
Merged
6 tasks
@daniel-anova daniel-anova mentioned this pull request Dec 15, 2022
Closed
@jackfrancis jackfrancis mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckotzbauer ckotzbauer ckotzbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timo-42 @ckotzbauer