Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for 1.4.0 release #133

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Update for 1.4.0 release #133

merged 2 commits into from
Apr 29, 2020

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Apr 14, 2020 •
edited
Loading

Tested on minikube with k8s 1.16.9, 1.17.5, 1.18.2.

@dholbach dholbach added this to the 1.4.0 milestone Apr 17, 2020
@dholbach
Copy link
Member Author

This largely refers to #127

I tested this in our Dev environment at Weaveworks too.

@dholbach
Copy link
Member Author

Looking at https://github.com/weaveworks/kured#kubernetes--os-compatibility and read "Kubernetes aims to provide forwards & backwards compatibility of one minor version between client and server" - I'm wondering should we have moved to 1.17 instead?

@evrardjp
Copy link
Collaborator

Yes it might be safer to have updated to just 1.17, but I don't think it's a big problem.
People can use version 1.3.0 until they upgrade to a k8s 1.16/1.17, for which they would be able to use 1.3.0, upgrade to 1.4.0, and then upgrade to k8s further. That's not good enough IMO.

@dholbach
Copy link
Member Author

Mh. Not sure - we could try to get back to 1.17 and be clearer about what we support.

@evrardjp
Copy link
Collaborator

evrardjp commented Apr 22, 2020 •
edited
Loading

I guess the one that puts the cycles into it can decide :)
Wanna discuss over it during the community meeting?

@dholbach
Copy link
Member Author

This will need changing once #135 is merged.

@dholbach dholbach self-assigned this Apr 22, 2020
@dholbach dholbach marked this pull request as draft April 22, 2020 16:36
Daniel Holbach added 2 commits April 29, 2020 15:21
Update for 1.4.0 release
ecd73fc 
	Tested on minikube with k8s 1.16.8, 1.17.4, 1.18.1
update compatibility matrix re: #135
779a9e2
@dholbach dholbach marked this pull request as ready for review April 29, 2020 13:24
evrardjp
evrardjp reviewed Apr 29, 2020
View reviewed changes
Copy link
Collaborator

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve when #135 has merged.

@dholbach dholbach merged commit 92ca18f into kubereboot:master Apr 29, 2020
@dholbach dholbach deleted the prep-1.4.0-release branch September 1, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evrardjp evrardjp evrardjp left review comments

Assignees

@dholbach dholbach

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dholbach @evrardjp