Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to crd-ref-docs 0.0.12 #1662

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 11, 2024

v0.0.9 had issues with Go 1.22 ( kubernetes-sigs/controller-tools#880 ), but this one is supposedly fixed with a more recent controller-tools version.

@xrstf xrstf requested a review from embik April 11, 2024 14:50
@xrstf xrstf self-assigned this Apr 11, 2024
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2024
@embik
Copy link
Member

embik commented Apr 12, 2024

supposedly

Have you run this script to test it out? I'm asking because it doesn't run on deployment preview.

@xrstf
Copy link
Contributor Author

xrstf commented Apr 12, 2024

Yes, I ran it. Hence why the generated index.html is changed in this PR.

@embik
Copy link
Member

embik commented Apr 12, 2024

Missed that because it was collapsed, sorry.

Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f9205b0c986a27a08460aa965bcb948746d4f2d8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@kubermatic-bot kubermatic-bot merged commit 25221ab into kubermatic:master Apr 12, 2024
11 checks passed
@xrstf xrstf deleted the bump-crd-gen branch April 12, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants