Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kubectl get/decribe aliases with completion #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eshepelyuk
Copy link
Contributor

@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign scheeles for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Inspired by work of https://github.com/msgongora
in https://github.com/msgongora/fubectl

Signed-off-by: Ievgenii Shepeliuk <eshepelyuk@gmail.com>
@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2024
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels May 21, 2024
@eshepelyuk
Copy link
Contributor Author

/assign @kron4eg
/assign @scheeles

@eshepelyuk
Copy link
Contributor Author

@msgongora FYI

@msgongora
Copy link

Hi @eshepelyuk, I deprecated this completion function since I migrated my shell to Zsh, and the alias completion came out of the box in this shell. I would suggest testing this in Zsh. In the function you could do something like [[ -n "$ZSH_VERSION" ]] && return 0

@eshepelyuk
Copy link
Contributor Author

Hello all

Is there any feedback on this ?

Regarding zsh - I have no possibility to setup zsh and research the PR behaviour in zsh. I will be appreciated if someone could test this in that shell. But I can conditionally enable this PR only for bash, so zsh users won't be affected.

@kron4eg
Copy link
Member

kron4eg commented Jun 24, 2024

I'm not sure I understand completely what's happening there

@eshepelyuk
Copy link
Contributor Author

I'm not sure I understand completely what's happening there
Hello @kron4eg
I've added more kubectl aliases for common operations, providing them with autocompletion function, that was implemented by @msgongora in his own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants