Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --export deprecation #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix --export deprecation #95

wants to merge 2 commits into from

Conversation

mehdiouzz
Copy link

This change resolves #91 by replacing --export with jq.
Signed-off-by: mehdiouzz el.mehdi.ouazzane@gmail.com

@mehdiouzz
fix export deprecation
b02ba75 
Signed-off-by: mehdiouzz <83595153+mehdiouzz@users.noreply.github.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2023
kron4eg
kron4eg reviewed Aug 23, 2023
View reviewed changes
fubectl.source
grep "$search_query" | \
jq -r '. | [.kind, .metadata.name] | @tsv' | \
awk -v prefix="$ns" '{print "kubectl get -n " prefix " " $0}'
search_query="$1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is already local search_query="$1"

fubectl.source Outdated Show resolved Hide resolved
@mehdiouzz
update list of resources
5c7e3e3 
Signed-off-by: mehdiouzz <83595153+mehdiouzz@users.noreply.github.com>
@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mehdiouzz
Once this PR has been reviewed and has the lgtm label, please assign toschneck for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mehdiouzz
Copy link
Author

@kron4eg apologies for the mistakes, still getting the hang of it
resource list is fixed, so is the search_query duplication
thanks for your review

@kron4eg
Copy link
Member

kron4eg commented Aug 26, 2023

@kron4eg apologies for the mistakes, still getting the hang of it resource list is fixed, so is the search_query duplication thanks for your review

you sill forgot to remove the search_query="$1" 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ksearch error: unknown flag: --export
3 participants
@mehdiouzz @kubermatic-bot @kron4eg