Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.6] Bump Golang version to 1.19.8 #2758

Merged
merged 3 commits into from
Apr 9, 2023
Merged

[release/v1.6] Bump Golang version to 1.19.8 #2758

merged 3 commits into from
Apr 9, 2023

Conversation

pkprzekwas
Copy link
Contributor

@pkprzekwas pkprzekwas commented Apr 6, 2023 •
edited
Loading

What this PR does / why we need it:
Bump Golang version to 1.19.8.

Which issue(s) this PR fixes:

Fixes https://github.com/kubermatic/release/issues/11

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Bump Golang version to 1.19.8.

Documentation:

NONE

@pkprzekwas pkprzekwas requested a review from xmudrii April 6, 2023 11:00
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.6 milestone Apr 6, 2023
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/chore Updating grunt tasks etc; no production code changes. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 6, 2023
@pkprzekwas pkprzekwas self-assigned this Apr 6, 2023
@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 6, 2023
xmudrii
xmudrii reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.

hack/images/kubeone-e2e/release.sh Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2023
@pkprzekwas
Copy link
Contributor Author

/retest

1 similar comment
@pkprzekwas
Copy link
Contributor Author

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 6, 2023

/test pull-kubeone-e2e-aws-default-install-containerd-v1.26.1

3 similar comments
@xmudrii
Copy link
Member

xmudrii commented Apr 6, 2023

/test pull-kubeone-e2e-aws-default-install-containerd-v1.26.1

@xmudrii
Copy link
Member

xmudrii commented Apr 6, 2023

/test pull-kubeone-e2e-aws-default-install-containerd-v1.26.1

@xmudrii
Copy link
Member

xmudrii commented Apr 6, 2023

/test pull-kubeone-e2e-aws-default-install-containerd-v1.26.1

@xmudrii
Copy link
Member

xmudrii commented Apr 6, 2023

/retest

xmudrii
xmudrii approved these changes Apr 9, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a non-blocking nit.
/approve

hack/images/kubeone-e2e/release.sh
TAG=v0.1.30
TAG=v0.1.31-go-1.19.8

export DOCKER_DEFAULT_PLATFORM=linux/amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bring this to main as well.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54631cd86948a00a516486bb1c5a4b45f12cd225

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2023
@xmudrii xmudrii added the cherry-pick-approved Indicates a PR has been approved by release managers. label Apr 9, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 9, 2023
@kubermatic-bot kubermatic-bot merged commit b748756 into kubermatic:release/v1.6 Apr 9, 2023
@schmitts schmitts mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@pkprzekwas pkprzekwas

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@pkprzekwas @xmudrii @kubermatic-bot