Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.7] Update CRDs for OSM #2935

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[release/v1.7] Update CRDs for OSM #2935

merged 1 commit into from
Oct 24, 2023

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #2933

/assign ahmedwaleedmalik

Update CRDs for operating-system-manager addon

@ahmedwaleedmalik
Update CRDs for OSM
6d6b59d 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot mentioned this pull request Oct 20, 2023
Merged
@kubermatic-bot kubermatic-bot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 20, 2023
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.7 milestone Oct 20, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: e3a124bff81071af960be47cb84bc09ba7cb3880

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@ahmedwaleedmalik
Copy link
Member

Requires #2936

@ahmedwaleedmalik
Copy link
Member

/test all

@ahmedwaleedmalik
Copy link
Member

/kind bug

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 23, 2023
@ahmedwaleedmalik
Copy link
Member

/assign @xmudrii

For sig-release review

@xmudrii xmudrii added the cherry-pick-approved Indicates a PR has been approved by release managers. label Oct 24, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 24, 2023
xmudrii
xmudrii approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit d086f8a into kubermatic:release/v1.7 Oct 24, 2023
13 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-2933-to-release/v1.7 branch October 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@xmudrii xmudrii xmudrii approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubermatic-bot @ahmedwaleedmalik @xmudrii