Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messaging when working with remote files over SSH #3052

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Improve error messaging when working with remote files over SSH #3052

merged 1 commit into from
Feb 23, 2024

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Feb 23, 2024

Which issue(s) this PR fixes:

Fixes #3047

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Improve error messaging when working with remote files over SSH

Documentation:

NONE

@kron4eg
Improve error messaging when working with remote files over SSH
54fe089 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 23, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 23, 2024
@kron4eg kron4eg marked this pull request as ready for review February 23, 2024 11:04
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 23, 2024
@kron4eg kron4eg requested a review from xmudrii February 23, 2024 11:05
xmudrii
xmudrii approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d829d55d06fbb2ffd379f7fa4c76cb4a2c9f3999

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@xmudrii
Copy link
Member

xmudrii commented Feb 23, 2024

/cherry-pick release/v1.7

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Feb 23, 2024

/cherry-pick release/v1.6

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member Author

kron4eg commented Feb 23, 2024

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Feb 23, 2024

/retest

@kubermatic-bot kubermatic-bot merged commit 89d1d6d into kubermatic:main Feb 23, 2024
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Feb 23, 2024
@kubermatic-bot kubermatic-bot mentioned this pull request Feb 23, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3053

In response to this:

/cherry-pick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3054

In response to this:

/cherry-pick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Feb 23, 2024
Merged
@kron4eg kron4eg deleted the ssh-vfs-error-messages branch February 24, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.

kubeone on bare-metal fails with error: ssh: popen Process exited with status 1
3 participants
@kron4eg @kubermatic-bot @xmudrii