Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow upgrade to the same Kubernetes version #315

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Allow upgrade to the same Kubernetes version #315

merged 1 commit into from
Mar 29, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 27, 2019

What this PR does / why we need it:

This PR changes the update preflight checks to allow updating to the same version if the --force flag is used. This ensure we can retry if the upgrade process failed for any reason.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #269

Release note:

Allow upgrades to the same version if the --force flag is used.

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg March 27, 2019 13:55
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 27, 2019
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2019
kron4eg
kron4eg approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 93ad7713683829befe1b69762c22a737df09e86e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Mar 27, 2019

/hold
Something is missing

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2019
@xmudrii
Allow upgrade to the same Kubernetes version
8755dcf 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@kron4eg
Copy link
Member

kron4eg commented Mar 27, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da663cd507c71a7ca6d6ac5f2c4ec10a8d106cc9

@xmudrii
Copy link
Member Author

xmudrii commented Mar 27, 2019

/test pull-kubeone-e2e-aws-conformance-1.13.5

@xmudrii
Copy link
Member Author

xmudrii commented Mar 27, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@xmudrii
Copy link
Member Author

xmudrii commented Mar 27, 2019

/test pull-kubeone-e2e-aws-conformance-1.13.5

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/hold cancel
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2019
@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

In response to this:

/hold cancel
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

In response to this:

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/test pull-kubeone-e2e-aws-conformance-1.14.0

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Mar 29, 2019 •
edited
Loading

@xmudrii: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 8755dcf link /test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

In response to this:

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 78ea337 into master Mar 29, 2019
@kubermatic-bot kubermatic-bot deleted the force-same-version branch March 29, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg