Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE integration #317

Merged
merged 11 commits into from
Mar 29, 2019
Merged

GCE integration #317

merged 11 commits into from
Mar 29, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Mar 27, 2019 •
edited
Loading

Fixes #278 #318

Added support for GCE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2019
@kron4eg kron4eg force-pushed the 278-gce-support branch 2 times, most recently from e248282 to b2964d2 Compare March 27, 2019 16:59
@xmudrii xmudrii mentioned this pull request Mar 28, 2019
Closed
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Mar 28, 2019

/retest

@kron4eg kron4eg added the lifecycle/blocked Denotes an issue or PR is blocked. label Mar 29, 2019
@kron4eg
update GCE terraform config
9aa1c06 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
GCE integration
f089c6e 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Adjust terraform config
8b3ad0f 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Upgrade machinecontroller to v1.1.2
59a3ef7 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Be explicit about port range
27d2d30 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Fix constant forwarding rule recreation
c325fa9 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
terraform trick
0158a45 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
double b64 encode GOOGLE_SERVICE_ACCOUNT
36938e8 
as machine-controller expects it in such way

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Use zoned terraform output for GCE
1340380 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Update GCE docs
8d9f305 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg changed the title WIP GCE integration GCE integration Mar 29, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2019
@kron4eg kron4eg requested a review from xmudrii March 29, 2019 15:43
@kron4eg kron4eg removed the lifecycle/blocked Denotes an issue or PR is blocked. label Mar 29, 2019
xmudrii
xmudrii reviewed Mar 29, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two tiny nitpicks, otherwise looks great!

examples/terraform/gce/README.md Show resolved Hide resolved
docs/quickstart-gce.md Outdated Show resolved Hide resolved
@kron4eg
gce: Few doc additions
7b0851a 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@xmudrii
Copy link
Member

xmudrii commented Mar 29, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54b06ab308c7ad394baee9bf31904076558b6609

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Mar 29, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kubermatic-bot kubermatic-bot merged commit 1e88279 into master Mar 29, 2019
@kubermatic-bot kubermatic-bot deleted the 278-gce-support branch March 29, 2019 17:05
@xmudrii xmudrii mentioned this pull request Apr 28, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @xmudrii @kubermatic-bot