Fix local helm releases deletion issue #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
docs/none
kron4eg
reviewed
Jun 18, 2024
kubermatic-bot
added
size/M
Read local chart name from Chart.yaml update the chart name check lint
mohamed-rafraf
force-pushed
the
helm-local
branch
from
56eb937
to
c97cb30
Compare
|
/approve |
|
LGTM label has been added. Git tree hash: 46a6bd4fc3a7b0e4b2e772d469c9f1fe95d55271
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
|
/kind bug |
kubermatic-bot
added
kind/bug
|
/cherrypick release/v1.8 |
|
@kron4eg: new pull request created: #3268 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
releasesFilterFnis used to filter out the helm releases that will be uninstalled. When using local helm charts, the helm releases can be deleted without any releases after applyingkubeone applyagain because we are comparing the Chart Name with the path of the Chart (HelmRelease.Chartis considered a chart path for local usage).This PR will allow kubeone to correctly read the chart name for local and remote helm charts!
Which issue(s) this PR fixes:
Fixes #3211
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: